Maor Lipchuk has posted comments on this change. Change subject: core: RemoveDiskSnapshots - sort non-consecutive images ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/34380/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java: Line 100: Line 101: /** Line 102: * Returns the images chain of the disk. Line 103: */ Line 104: protected List<DiskImage> getAllImages() { Please change the name to getAllImagesForDisk Line 105: return getDiskImageDao().getAllSnapshotsForImageGroup(getImageGroupId()); Line 106: } Line 107: Line 108: protected SnapshotsValidator getSnapshotsValidator() { -- To view, visit http://gerrit.ovirt.org/34380 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia736aa93a76dd8df13bfdcf97587cee82bea6700 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
