Doron Fediuck has posted comments on this change.

Change subject: pki: remove the need to store ssh public key
......................................................................


Patch Set 4: (2 inline comments)

Alon,

Please fix the location.
Otherwise I feel better with the new implementation.

Juan, what's your view on it?

....................................................
File backend/manager/modules/root/pom.xml
Line 33:     
Please remove TWS.

....................................................
File 
backend/manager/modules/root/src/main/java/org/ovirt/engine/core/PKIResource.java
Line 1: package org.ovirt.engine.core;
Please take a look at RegisterServlet.
We try to keep servlets in a specific area and namespace, 
as this is not really an internal part of the backend.

--
To view, visit http://gerrit.ovirt.org/4853
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I328baded92b2e7c5169bc87e7c19680f598389b9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to