Moti Asayag has posted comments on this change. Change subject: core: Replace oVirt logger with slf4j in bll ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/34359/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java: Line 113: log.error("CommandsFactory : Failed to get type information using reflection for Class '{}', Command Id '{}': {}", Line 114: className, Line 115: commandId, Line 116: e.getMessage()); Line 117: log.debug("Exception", e); > not sure about this as well, yair? stackstace might be useful to figure out what went wrong: either an expected c'tor is missed (i.e. for compensation) or some NPE as a result of some work being done on a specific c'tor or else. Line 118: return null; Line 119: } finally { Line 120: if (isAcessible != null) { Line 121: constructor.setAccessible(isAcessible); Line 139: } Line 140: return result; Line 141: } catch (Exception e) { Line 142: log.error("Command Factory: Failed to create command '{}' using reflection: {}", type, e.getMessage()); Line 143: log.debug("Exception", e); same here. Line 144: throw new RuntimeException(e); Line 145: } Line 146: } Line 147: -- To view, visit http://gerrit.ovirt.org/34359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82070b252197458422792c49b2135fcb9b9b1430 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
