Yedidyah Bar David has posted comments on this change. Change subject: core: do not allow execute process with non string argument or environment ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/34486/3/src/otopi/plugin.py File src/otopi/plugin.py: Line 773: Line 774: def _isString(s): Line 775: return ( Line 776: isinstance(v, str) or Line 777: isinstance(v, builtins.unicode) perhaps simply basestring, we'll have to fix this for python3 anyway Line 778: ) Line 779: Line 780: try: Line 781: if envAppend is not None: Line 797: if not _isString(v): Line 798: raise RuntimeError( Line 799: _( Line 800: "Bad argument when trying to execute {args}, " Line 801: "Malformed argument is {argType}{arg}." type:arg? Line 802: ).format( Line 803: args=args, Line 804: argType=type(v), Line 805: arg=v, -- To view, visit http://gerrit.ovirt.org/34486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d79c4e29451779a0d98942de3bca1525a15c0ab Gerrit-PatchSet: 3 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
