Moti Asayag has uploaded a new change for review. Change subject: engine: Extract method of network compliance check ......................................................................
engine: Extract method of network compliance check Change-Id: Iadc66b853055b7237f9dbe78793f53bb20299b04 Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java 1 file changed, 10 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/63/34563/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java index 0a8fed1..f352245 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java @@ -86,15 +86,21 @@ return NonOperationalReason.VM_NETWORK_IS_BRIDGELESS; } - final Map<String, Network> clusterNetworksByName = Entities.entitiesByName(clusterNetworks); - final Collection<Network> dbHostNetworks = findNetworksOnInterfaces(dbIfaces, clusterNetworksByName); - logChangedDisplayNetwork(host, dbHostNetworks, dbIfaces); - logUnsynchronizedNetworks(host, clusterNetworksByName); + auditNetworkCompliance(host, dbIfaces, clusterNetworks); } return NonOperationalReason.NONE; } + public void auditNetworkCompliance(VDS host, + List<VdsNetworkInterface> dbIfaces, + final List<Network> clusterNetworks) { + Map<String, Network> clusterNetworksByName = Entities.entitiesByName(clusterNetworks); + final Collection<Network> dbHostNetworks = findNetworksOnInterfaces(dbIfaces, clusterNetworksByName); + logChangedDisplayNetwork(host, dbHostNetworks, dbIfaces); + logUnsynchronizedNetworks(host, clusterNetworksByName); + } + @Override public NonOperationalReason persistAndEnforceNetworkCompliance(VDS host) { return persistAndEnforceNetworkCompliance(host, false, Collections.<VdsNetworkInterface> emptyList()); -- To view, visit http://gerrit.ovirt.org/34563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iadc66b853055b7237f9dbe78793f53bb20299b04 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
