Sandro Bonazzola has posted comments on this change.

Change subject: packaging: setup: Stop remote dwh
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/34566/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dwh.py
File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dwh.py:

Line 63:                     'name': 'DisconnectDwh',
Line 64:                     'value': value,
Line 65:                 },
Line 66:             ),
Line 67:             ownConnection=True,
> This is needed, but should be harmless. we just turn if on and off. If we f
Maybe better to add a comment line here for this.
Line 68:         )
Line 69: 
Line 70:     @plugin.event(
Line 71:         stage=plugin.Stages.STAGE_INIT,


-- 
To view, visit http://gerrit.ovirt.org/34566
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7e345bf71c2a5ecdddc777487d67fcae9d4b84a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Shirly Radco <[email protected]>
Gerrit-Reviewer: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to