Yevgeny Zaspitsky has uploaded a new change for review. Change subject: engine: Update AddBondCommand logic ......................................................................
engine: Update AddBondCommand logic Replace the call to legacy NetworkUtils.isManagementNetwork by the call to ManagementNetworkUtil class. Change-Id: I4e07bbaae24559d5df752c065aca6e8d841ba225 Signed-off-by: Yevgeny Zaspitsky <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddBondCommand.java 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/21/33821/14 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddBondCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddBondCommand.java index a1b1126..b0cf55e 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddBondCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddBondCommand.java @@ -2,7 +2,10 @@ import java.util.List; +import javax.inject.Inject; + import org.apache.commons.lang.StringUtils; +import org.ovirt.engine.core.bll.network.cluster.ManagementNetworkUtil; import org.ovirt.engine.core.bll.network.cluster.NetworkClusterHelper; import org.ovirt.engine.core.common.AuditLogType; import org.ovirt.engine.core.common.action.AddBondParameters; @@ -19,6 +22,9 @@ import org.ovirt.engine.core.utils.linq.Predicate; public class AddBondCommand<T extends AddBondParameters> extends VdsBondCommand<T> { + + @Inject + private ManagementNetworkUtil managementNetworkUtil; public AddBondCommand(T parameters) { super(parameters); @@ -137,7 +143,7 @@ } if (StringUtils.isNotEmpty(getParameters().getGateway()) && - !NetworkUtils.isManagementNetwork(getParameters().getNetwork())) { + !managementNetworkUtil.isManagementNetwork(getParameters().getNetwork().getId(), getVdsGroupId())) { addCanDoActionMessage(VdcBllMessages.NETWORK_ATTACH_ILLEGAL_GATEWAY); return false; } -- To view, visit http://gerrit.ovirt.org/33821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4e07bbaae24559d5df752c065aca6e8d841ba225 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
