Vojtech Szocs has posted comments on this change. Change subject: webadmin: UI plugin event handler ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34570/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractTabPresenter.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractTabPresenter.java: Line 68: */ Line 69: protected abstract ActionTable<?> getTable(); Line 70: Line 71: @Inject Line 72: public void setActionButtonPluginHandler(ActionButtonPluginHandler actionButtonPluginHandler) { > We have wayyyyy to many eager singletons as it is (I really want to reduce OK, fair enough :-) Reducing the number of eager singletons is a good idea, but please be careful - lazy singletons might miss some early events. In general, you can rely on dependency resolution upon component creation. Assume component A is eager singleton; if component A injects dependencies B and C, then B and C will essentially act as eager singletons too, even though they might be declared in code as lazy singletons. Line 73: this.actionButtonPluginHandler = actionButtonPluginHandler; Line 74: } -- To view, visit http://gerrit.ovirt.org/34570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83ad213a1dca8d31cf63c6b2c5f761f3242b43bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
