Eli Mesika has posted comments on this change. Change subject: core: disable the mixing of RHEL6 and RHEL7 in one cluster ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/34653/4/packaging/dbscripts/vds_sp.sql File packaging/dbscripts/vds_sp.sql: Line 1126: AS $procedure$ Line 1127: BEGIN Line 1128: BEGIN Line 1129: -- both centos and RHEL return RHEL as host_os Line 1130: RETURN QUERY select * from vds where (host_os like 'RHEL%' or host_os like 'oVirt Node%' or host_os like 'RHEV Hypervisor%') and status = 3 and vds_group_id = v_vds_group_id LIMIT 1; I don;t like this usage of static strings in query which might fail when the string is changed, why this information is not stored in an enum that we can store as int in DB and query for it ??? Line 1131: END; Line 1132: Line 1133: RETURN; Line 1134: END; $procedure$ -- To view, visit http://gerrit.ovirt.org/34653 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb6d41b1921a6caf946cba44a6c92ef86fef6bc8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
