Martin Mucha has posted comments on this change. Change subject: restapi: fix NPE on ReloadConfigurationsCommand ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34649/1/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java: Line 712: ParentToCollectionMap collections = TYPES.get(model.getClass()); Line 713: Line 714: if (collections == null) { Line 715: log.error("Map 'describing every possible collection' does not contain rather possible key for resource " + Line 716: "%1$s, returning 'null' instead.", model.getClass()); > Shouldn't you use {} instaed of %1$s? message removed altogether as we settled, due to API.class is not entity, does not have any related Collection and should not be registered in TYPES map. Line 717: return null; Line 718: } Line 719: Line 720: if (suggestedParentType != null) { -- To view, visit http://gerrit.ovirt.org/34649 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70fd6b084a33bc7770de245c0001d3eefbb58b66 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
