Martin Peřina has posted comments on this change. Change subject: core: Fire CDI event with all reloaded VdcOptions upon ReloadConfigurationsCommand ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/34657/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ReloadConfigurationsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ReloadConfigurationsCommand.java: Line 43: public AuditLogType getAuditLogTypeValue() { Line 44: return getSucceeded() ? AuditLogType.RELOAD_CONFIGURATIONS_SUCCESS : AuditLogType.RELOAD_CONFIGURATIONS_FAILURE; Line 45: } Line 46: Line 47: public class VdcOptionsUpdated { Please move this class into its own file (probably to org.ovirt.engine.core.common.config), because it's used other classes and not only this one. And I would also rename it to UpdatedConfigValues Line 48: private final List<VdcOption> updatedVdcOptions; Line 49: Line 50: public VdcOptionsUpdated(List<VdcOption> updatedVdcOptions) { Line 51: this.updatedVdcOptions = Collections.unmodifiableList(updatedVdcOptions); -- To view, visit http://gerrit.ovirt.org/34657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89b1d94626b4210cd2a7fb04efc4ee9cc490dd6c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
