Ravi Nori has uploaded a new change for review. Change subject: engine : Set endAction try again to false on failure ......................................................................
engine : Set endAction try again to false on failure When an exception in execute causes endWithFailure to be invoked, if no handlers have been run the command/handlers don't get a chance to call setEndActionTryAgain to false. This could cause the AsyncTaskManager to continue running endAction for the command and the command would not converge. Change-Id: Idf6f8755a22f2654b9af6678f1353f9b6ae08942 Bug-Url: https://bugzilla.redhat.com/1159325 Signed-off-by: Ravi Nori <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/02/34702/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java index 90a09bd..5540d58 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java @@ -649,6 +649,9 @@ if (hasStepsToRevert()) { getCurrentTaskHandler().endWithFailure(); revertPreviousHandlers(); + } else { + // since no handlers have been run we don't have to retry endAction + getReturnValue().setEndActionTryAgain(false); } startPollingAsyncTasks(); } else { -- To view, visit http://gerrit.ovirt.org/34702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idf6f8755a22f2654b9af6678f1353f9b6ae08942 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
