Arik Hadas has posted comments on this change. Change subject: core: Check live snapshot capabilities in live storage migration CDA ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/34612/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/LiveSnapshotHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/LiveSnapshotHelper.java: Line 10: LiveSnapshotHelper how about rename it to LiveSnapshotValidator to conform the convention and make its methods non-static ? -- To view, visit http://gerrit.ovirt.org/34612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idba6581587d1908e4428ea2d18878c2f62a0b317 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
