Lev Veyde has posted comments on this change. Change subject: packaging: setup: Add ISO and VFD uploading plugin ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/34760/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/__init__.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/__init__.py: Line 37: nfs.Plugin(context=context) Line 38: exportfs.Plugin(context=context) Line 39: selinux.Plugin(context=context) Line 40: image_upload.Plugin(context=context) Line 41: > please use 2 blank lines here Done http://gerrit.ovirt.org/#/c/34760/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/image_upload.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/image_upload.py: Line 74: os.path.join( Line 75: osetupcons.FileLocations.OVIRT_GUEST_TOOLS_DIR, Line 76: 'ovirt-tools-setup.iso', Line 77: ), Line 78: ] > looks like here there's a tab instead of spaces, please use only spaces Done Line 79: Line 80: @plugin.event( Line 81: stage=plugin.Stages.STAGE_VALIDATION, Line 82: condition=lambda self: ( -- To view, visit http://gerrit.ovirt.org/34760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34b5c4ab5a16bf56c4b77b40bb76080d9420eede Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lev Veyde <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
