Alona Kaplan has posted comments on this change. Change subject: engine: Implement HostNetworkQosValidator ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/34123/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostNetworkQosValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostNetworkQosValidator.java: Line 35: : ValidationResult.VALID; Line 36: } Line 37: Line 38: @Override Line 39: protected QosDao<HostNetworkQos> getQosDao() { > Is this method needed? Because this method is abstract. Line 40: return DbFacade.getInstance().getHostNetworkQosDao(); Line 41: } Line 42: -- To view, visit http://gerrit.ovirt.org/34123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf156e27381111efb3d9abac3e6e37ccdd8f7643 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
