Francesco Romani has posted comments on this change.

Change subject: Add scheduling filter that prevents migration to same host
......................................................................


Patch Set 5: Verified+1

shouldn't the script been named

03_06_0520_add_migration_policy_unit.sql

? (please note four digits after 03_06)

AFAIK it is relevant here

I had to run this script manually, engine-setup.py didn't run - or, can't tell 
that, it run and it was overwritten somehow.

Besides that, verified using these steps:
    new oVirt setup, added a couple of hosts, one by specifuing the IP as 
hostname (hostA), one using symbolic name (hostB)
    did the rest of the setup (storage domain, test VM)
    verified migrations and run vm works as expected (no regressions)
    same for run once
    changed /etc/hosts on the Engine host
    forced hostB to have the same address as hostA. Migration was denied by 
Engine as expected
    forced hostB to have loopback address (127.0.0.x for the sake of 
completeness). Migration was denied by Engine as expected

-- 
To view, visit http://gerrit.ovirt.org/34700
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42021452205f3dc070388a43de92c8fd5ed6dbf2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Jiří Moskovčák <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomer Saban <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to