Alon Bar-Lev has posted comments on this change. Change subject: engine: Method to fetch SSH fingerprint of server ......................................................................
Patch Set 4: Hi, Please always rebase patches... I've moved the @Override to base patch. Imaging this sequence... 1. Connect to destination X using IP A, get finger print, disconnect. 2. Connect to IP A, send credentials. Looks correct, isn't it? What if destination X changes IP address between (1) and (2)? Because of that, it is impossible to connect without validation of destination fingerprint. For the agile argument... well, I am relatively new here in oVirt, however floating features within product is not something that is wise. A better process is to write several patches then either merge them at same time or cherry pick them into single commit. But having floating features that may or may not be used in future has maintenance costs. Anyway, it is not that important for this simple change, as we do have the functionality anyway. I will add something similar to the core patch, superseding this one. Thanks. -- To view, visit http://gerrit.ovirt.org/6927 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I398fac6cbf641b49c8281937280ae0c351e1d3b6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dhandapani Gopal <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
