Liron Aravot has posted comments on this change. Change subject: core: OVFs that aren't stored on any domain should be stored on all ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/34292/4/packaging/dbscripts/vms_sp.sql File packaging/dbscripts/vms_sp.sql: Line 592: Line 593: Line 594: Line 595: Line 596: Create or replace FUNCTION GetVmsAndTemplatesIdsWithoutAttachedImageDisks(v_shareable BOOLEAN) > What about changing this to VMS as you agreed in the first patch please take another look, it's changed (now it's Vms). Line 597: RETURNS SETOF UUID STABLE Line 598: AS $procedure$ Line 599: BEGIN Line 600: RETURN QUERY SELECT vs.vm_guid Line 601: FROM vm_static vs Line 602: WHERE vs.vm_guid NOT IN (SELECT DISTINCT vd.vm_id Line 603: FROM vm_device vd INNER JOIN base_disks i Line 604: ON i.disk_id = vd.device_id Line 605: AND vd.snapshot_id IS NULL > What is this? 1. It can be either place, it's matter of preference. If you find it more readable to you in the WHERE clause i'll move it there. 2. I don't want to do that as there's absolutely no case that the null case is used, i've added the v_shareable parameter just to not have the logic reside within the db level. If we'll ever need the "null" case, we can add it then. Line 606: WHERE i.shareable = v_shareable); Line 607: END; $procedure$ Line 608: LANGUAGE plpgsql; Line 609: -- To view, visit http://gerrit.ovirt.org/34292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaeecc6c4526800656315842384d83830fdf0b72b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
