Tal Nisan has posted comments on this change. Change subject: webadmin: Warning message for cloning a VM with LUN. ......................................................................
Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/34786/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/CloneVmWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/CloneVmWidget.java: Line 68: @Override Line 69: public void edit(final CloneVmModel object) { Line 70: driver.edit(object); Line 71: Line 72: object.getPropertyChangedEvent().addListener(new IEventListener<PropertyChangedEventArgs>() { You don't need that, it will bind automatically since you gave it the path "Message.entity", check out the implementation in VmExportPopupView for instance Line 73: @Override Line 74: public void eventRaised(Event<? extends PropertyChangedEventArgs> ev, Object sender, PropertyChangedEventArgs args) { Line 75: String propName = args.propertyName; Line 76: if ("Message".equals(propName)) { //$NON-NLS-1$ -- To view, visit http://gerrit.ovirt.org/34786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb2d5205baaadd17646b5076bf5f3add481f0709 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
