Lior Vernia has posted comments on this change. Change subject: engine: Implement HostNetworkQos [de]serialization ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/34122/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkQosMapper.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkQosMapper.java: Line 56: if (outboundEntry == null) { Line 57: return null; Line 58: } Line 59: Line 60: HostNetworkQos qos = new HostNetworkQos(); > The ui resides on the fact that anonymous HostNetworkQos doesn't have stora Will add a comment here in the next patchset. I think the other half you're describing should be implemented as annotations on the QoS member of the VdsNetworkInterface, and have those entities validated somehow - as part of host interface persistence flow? What do you think? Line 61: qos.setOutAverageLinkshare(deserializeValue(outboundEntry, VdsProperties.HOST_QOS_LINKSHARE)); Line 62: qos.setOutAverageUpperlimit(deserializeValue(outboundEntry, VdsProperties.HOST_QOS_UPPERLIMIT, MBITS_TO_BITS)); Line 63: qos.setOutAverageRealtime(deserializeValue(outboundEntry, VdsProperties.HOST_QOS_REALTIME, MBITS_TO_BITS)); Line 64: return qos; -- To view, visit http://gerrit.ovirt.org/34122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fab9e53938823463ff01af0a153390804f276c3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
