Yair Zaslavsky has posted comments on this change. Change subject: xmlrpc: marshalling of Long type ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/34854/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java: Line 53: Line 54: private static final String HTTP = "http://";; Line 55: private static final String HTTPS = "https://";; Line 56: private static final Logger log = LoggerFactory.getLogger(XmlRpcUtils.class); Line 57: private static final Set<String> METHOD_LIST = new HashSet<String>(Arrays.asList("")); METHOD_LIST is a bad name, IMHO. a. Change it to METHODS - METHOD_LIST should be list, not hashset. but why limit yourself to data structure in the name b. Maybe - SUPPORTED_METHODS_FOR_LONG_CONVERSION ? Line 58: static { Line 59: if (Config.<Boolean> getValue(ConfigValues.EncryptHostCommunication)) { Line 60: URL keystoreUrl; Line 61: try { -- To view, visit http://gerrit.ovirt.org/34854 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97ffc2da3703dbf7ce58607b7461a02aea35f2bb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
