Lior Vernia has posted comments on this change. Change subject: webadmin: Add full host network QoS dialogs ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/34128/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/RemoveQosModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/RemoveQosModel.java: Line 46: Line 47: @Override Line 48: public abstract String getTitle(); Line 49: Line 50: protected abstract VdcQueryType getProfilesByQosIdQueryType(); > Consider changing the name, since in case of HostNetwork is is not a profil Done Line 51: Line 52: protected abstract String getRemoveQosMessage(int size); Line 53: Line 54: protected abstract String getRemoveQosHashName(); Line 68: Frontend.getInstance().runMultipleQueries(queryTypes, parameters, new IFrontendMultipleQueryAsyncCallback() { Line 69: Line 70: @Override Line 71: public void executed(FrontendMultipleQueryAsyncResult result) { Line 72: Map<String, String> profilesAndQos = new HashMap<String, String>(); > same here. Done Line 73: Line 74: setHelpTag(getRemoveQosHelpTag()); Line 75: setHashName(getRemoveQosHashName()); Line 76: Line 75: setHashName(getRemoveQosHashName()); Line 76: Line 77: int index = 0; Line 78: for (VdcQueryReturnValue returnValue : result.getReturnValues()) { Line 79: for (Nameable profileBase : (List<Nameable>) returnValue.getReturnValue()) { > and here:) Done Line 80: profilesAndQos.put(profileBase.getName(), sourceListModel.getSelectedItems() Line 81: .get(index) Line 82: .getName()); Line 83: } -- To view, visit http://gerrit.ovirt.org/34128 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I212708b25777f5d11245a610d4d767f634cb9f88 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
