Piotr Kliczewski has posted comments on this change. Change subject: core: configurable ssl protocol ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/34372/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java: Line 370: int hostPort = hostUrl.getPort() == -1 ? HttpsURL.DEFAULT_PORT : hostUrl.getPort(); Line 371: Protocol httpsProtocol = Line 372: new Protocol(String.valueOf(HttpsURL.DEFAULT_SCHEME), Line 373: (ProtocolSocketFactory) new AuthSSLProtocolSocketFactory(ExternalTrustStoreInitializer.getTrustStore(), Line 374: Config.<String> getValue(ConfigValues.ProviderSSLProtocol)), > exactly the opposite. Here is last part of our conversation: <alonbl> pkliczew: so we either need two configuration options <alonbl> pkliczew: or we use one for 3.4.z <pkliczew> alonbl, in this case second config options is OK <alonbl> pkliczew: ok, fine by me as well <alonbl> yzaslavs: for 3.5/3.6 we will have to get this part of the entity but I can use sslv3 here. It will be easier for Yair to work with. Line 375: hostPort); Line 376: httpClient.getHostConfiguration().setHost(hostUrl.getHost(), hostPort, httpsProtocol); Line 377: } else { Line 378: int hostPort = hostUrl.getPort() == -1 ? HttpURL.DEFAULT_PORT : hostUrl.getPort(); -- To view, visit http://gerrit.ovirt.org/34372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33a33c15e8a995eb8de7d5131b3dbadc6191f873 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
