Michael Pasternak has posted comments on this change. Change subject: sdk: Apply filter by name/alias after get ......................................................................
Patch Set 2: Code-Review+2 (1 comment) alright, then i remove my objection, but if you won't succeeded in your adventure, please consider solution i've proposed. http://gerrit.ovirt.org/#/c/34892/2/src/ovirtsdk/infrastructure/brokers.py File src/ovirtsdk/infrastructure/brokers.py: Line 2598: ).get_cluster() Line 2599: Line 2600: return Cluster( Line 2601: FilterHelper.getItem( Line 2602: FilterHelper.filter(result, {'name':name}), > In this situation FilterHelper.filter is called first, to discard the objec sorry mate, i didn't explained myself well enough, i was talking about original bug in CLI (that triggered this change) where was deleted first entity in collection when get(name=X) called with filter=true, i.e ?search ignored & entire collection returned, so FilterHelper.getItem() was suppose to throw error? no? Line 2603: query="name=" + name Line 2604: ), Line 2605: self.context Line 2606: ) -- To view, visit http://gerrit.ovirt.org/34892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9baf549c68a93f329b76d41a2ce52b7a7e7b6c79 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
