Tomas Jelinek has posted comments on this change. Change subject: webadmin: CPU Type and CPU Architecture fields in Cluster dialog fix ......................................................................
Patch Set 2: (2 comments) very small comments, otherwise looks fine http://gerrit.ovirt.org/#/c/34816/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/FilteredListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/FilteredListModel.java: Line 25: } Line 26: } Line 27: Line 28: /** Line 29: * It filters items in this list model. Items are shown iff s/iff/if Line 30: * {@link org.ovirt.engine.ui.uicommonweb.models.FilteredListModel.Filter#filter(Object)} returns true. Line 31: * Input collection for filtering is the last collection passed to {@link #setItems(java.util.Collection, Object)} Line 32: * @param filter filter; {@code null} means 'show all' Line 33: */ Line 34: public void filterItems(Filter<T> filter) { Line 35: if (filter == null) { Line 36: if (ObjectUtils.objectsEqual(this.allItems, getItems())) { Line 37: return; Line 38: } else { no need for the else block since you have used the "return" Line 39: setItemsSelectionAware(this.allItems); Line 40: } Line 41: } Line 42: final Collection<T> itemsToShow = new ArrayList<T>(); -- To view, visit http://gerrit.ovirt.org/34816 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c0452426f58f09703382495a9527fdbe859d80e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <[email protected]> Gerrit-Reviewer: Jakub Niedermertl <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
