Daniel Erez has posted comments on this change. Change subject: webadmin: Support import file Storage Domain with different type ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/35019/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-11-11 10:40:35 +0200 Line 6: Line 7: webadmin: Support import file Storage Domain with different type Line 8: Line 9: Support import of File Storage Domain with different type then what is /then/than Line 10: mentioined in the meta data Line 11: Line 12: Change-Id: I9359069c3bbe6a2ebfa6f1d0e58bd62c5ad02197 Line 13: Bug-Url: https://bugzilla.redhat.com/1157240 http://gerrit.ovirt.org/#/c/35019/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java: Line 2064: StorageListModel storageListModel1 = (StorageListModel) target; Line 2065: ArrayList<StorageDomain> domains = (ArrayList<StorageDomain>) returnValue; Line 2066: if (domains != null && !domains.isEmpty()) { Line 2067: for (StorageDomain storageDomain : domains) { Line 2068: storageDomain.setStorageType(storageType); why do we need to change the storage type? is it always applicable? Line 2069: } Line 2070: storageListModel1.importFileStorageAddDomain(domains); Line 2071: } Line 2072: else { -- To view, visit http://gerrit.ovirt.org/35019 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9359069c3bbe6a2ebfa6f1d0e58bd62c5ad02197 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
