Sandro Bonazzola has posted comments on this change. Change subject: iscsi: add HE disk to the engine as direct lun ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/34783/5/src/plugins/ovirt-hosted-engine-setup/engine/add_disk.py File src/plugins/ovirt-hosted-engine-setup/engine/add_disk.py: Line 164: ) Line 165: ) Line 166: found = True Line 167: break Line 168: if not found: > you can rewrite this as: Done Line 169: engine_api.disks.add(disk) Line 170: except ovirtsdk.infrastructure.errors.RequestError: Line 171: self.logger.debug( Line 172: 'Cannot add the Hosted Engine VM Disk to the engine', -- To view, visit http://gerrit.ovirt.org/34783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c5640bde713fc4d09cf74a7037c62e833495934 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
