Sandro Bonazzola has posted comments on this change. Change subject: iscsi: checking image size against VG free space ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/34940/7/src/ovirt_hosted_engine_setup/constants.py File src/ovirt_hosted_engine_setup/constants.py: Line 277: HOSTED_ENGINE_VM_NAME = 'HostedEngine' Line 278: # On block devices the VM image should be preallocated into the VG Line 279: # The VG by itself introduces some overhead that we need to take care of Line 280: # verifying the image size before creating them Line 281: # TODO get this values from VDSM APIs instead of hardcoding it > There are no such api, but it can be easy to add it. +1 on having it exposed somehow in vdsm Line 282: # TODO now the overhead is > 4GBiB cause we are creating a storage domain Line 283: # maybe we can do better Line 284: BLOCKDEVICE_OVERHEAD_GIB = 5 Line 285: METADATA_CHUNK_SIZE = 4096 -- To view, visit http://gerrit.ovirt.org/34940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17f861a053f6ac38983967ffb07ecca9ff9b8de1 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
