Greg Sheremeta has uploaded a new change for review. Change subject: webadmin: fix icons on role popup ......................................................................
webadmin: fix icons on role popup At some point, the role icons in RoleView were stretched to 30px tall. They looked ridiculous. Fixed. Change-Id: Id804691ba5799ca86733e4cba063b7ceb8774aae Signed-off-by: Greg Sheremeta <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RoleView.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 2 files changed, 6 insertions(+), 11 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/59/35059/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RoleView.ui.xml b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RoleView.ui.xml index 80ff74a..e86d4d4 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RoleView.ui.xml +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RoleView.ui.xml @@ -12,9 +12,10 @@ .imageStyle { vertical-align: bottom; - height: 30px; - line-height: 25px; - margin-left: 10px; + position: relative; + top: -5px; + margin-right: 5px; + margin-left: 15px; } </ui:style> @@ -22,9 +23,9 @@ <g:HorizontalPanel> <g:Label ui:field="showLabel" addStyleNames="{style.labelStyle} rv_showLabel_pfly_fix"/> <g:RadioButton name="rolesRadioButton" ui:field="allRolesRadioButton" addStyleNames="rv_radio_pfly_fix"/> - <g:Image resource='{resources.adminImage}' addStyleNames="{style.imageStyle} rv_image_pfly_fix"/> + <g:Image resource='{resources.adminImage}' addStyleNames="{style.imageStyle}"/> <g:RadioButton name="rolesRadioButton" ui:field="adminRolesRadioButton" addStyleNames="rv_radio_pfly_fix"/> - <g:Image resource='{resources.userImage}' addStyleNames="{style.imageStyle} rv_image_pfly_fix"/> + <g:Image resource='{resources.userImage}' addStyleNames="{style.imageStyle}"/> <g:RadioButton name="rolesRadioButton" ui:field="userRolesRadioButton" addStyleNames="rv_radio_pfly_fix"/> </g:HorizontalPanel> <g:SimplePanel ui:field="rolesTabContent" height="495px" /> diff --git a/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css b/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css index 6d8441a..46b54f9 100644 --- a/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css +++ b/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css @@ -273,12 +273,6 @@ margin-bottom: 0; padding-bottom: 0; } -.rv_image_pfly_fix { - position: relative; - top: -5px; - margin-right: 5px; - margin-left: 15px !important; -} .footerButton_pfly_fix { height: 22px; } -- To view, visit http://gerrit.ovirt.org/35059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id804691ba5799ca86733e4cba063b7ceb8774aae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
