Alona Kaplan has posted comments on this change. Change subject: core: Introduce BusinessEntityMap ......................................................................
Patch Set 13: (2 comments) http://gerrit.ovirt.org/#/c/33329/13/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntityMap.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntityMap.java: Line 5: import java.util.Map; Line 6: Line 7: import org.ovirt.engine.core.compat.Guid; Line 8: Line 9: public class BusinessEntityMap<E extends BusinessEntity<Guid> & Nameable> { Please add java doc to this class. Line 10: private Map<String, E> entitiesByName; Line 11: private Map<Guid, E> entitiesById; Line 12: Line 13: // added for the sake of checkstyle rule Line 19: entitiesByName = new HashMap<String, E>(); Line 20: entitiesById = new HashMap<Guid, E>(); Line 21: Line 22: for (E e : entities) { Line 23: if (e.getName() != null) { Please use Entites.entitiesByName and Entites.businessEntitiesById to avoid duplicating logic. Line 24: entitiesByName.put(e.getName(), e); Line 25: } Line 26: Line 27: if (e.getId() != null) { -- To view, visit http://gerrit.ovirt.org/33329 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4540f813f8a787a38ba3e692b6ddd3fcc6be536a Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
