Doron Fediuck has posted comments on this change.
Change subject: core: simplify 'is null' sql expression
......................................................................
Patch Set 1: I would prefer that you didn't submit this
Laszlo,
This case handles both NULL searches, and empty strings ("''").
These are not the same. Can you make sure this is not a bug?
ie-
(value = '') != (value is null)
--
To view, visit http://gerrit.ovirt.org/7047
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d186f0f354026086a7f7039deaca1c236cfc7be
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
