Moti Asayag has posted comments on this change.
Change subject: core:No need to call super method for job properties(#818295)
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
Line 465: jobProperties = new HashMap<String, String>();
it won't work well:
The message says:
job.ImportVmTemplate=Importing VM Template ${VmTemplate} to Data Center
${StoragePool}
Here you provide the VmTemplate only. StoragePool will be set to UNKNOWN.
You should handle it as well - either by providing a value to it or omitting it
from the message. Since templates are on DC level i think it shouldn't be
removed.
--
To view, visit http://gerrit.ovirt.org/7045
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib92221db99df6d1fc4178cbab8375d6ea4d8a9c2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
