Moti Asayag has posted comments on this change. Change subject: engine: Use specific method to resolve command classes ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35078/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java: Line 81 Line 82 Line 83 Line 84 Line 85 > so COMMAND_SUFFIX was reundant in the first place? sure - we have on this class: public static Class<CommandBase<? extends VdcActionParametersBase>> getCommandClass(String name) { return getCommandClass(name, COMMAND_SUFFIX); } which overloads private static Class<CommandBase<? extends VdcActionParametersBase>> getCommandClass(String name, String suffix) { ... } so no need to read the latter explicitly, only via the getQueryClass and getCommandClass But there seems to be less distingush between the type of the commands: there are Queries and Commands, but we refers to both as Commands. So we might need some more work to this class and also - Backend.runQueryImpl() seems to be problematic, since it tries to resolve a Query class, while actually all the getQueryClass should expect Class<QueriesCommandBase<? extends VdcQueryParametersBase>> instead of the returned value which refers to CommandBase children. but i'll keep that for future patches. -- To view, visit http://gerrit.ovirt.org/35078 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ec45e31f7c72dd5659e1b5fcb81a632cb8b34d4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
