Allon Mureinik has posted comments on this change. Change subject: core: cleanup VmConditionFieldAutoCompleter ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java Line 136: Date tmp = new Date(Date.parse(StringHelper.trim(value.argvalue, '\''))); Why is new Date() called here? Date.parse() returns a new Date object anyway. Moreover, this is deprecated - you should use DateFormat.parse() -- To view, visit http://gerrit.ovirt.org/7042 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38fd88727e5d4a58f6de229e38db70daded596f4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
