Omer Frenkel has posted comments on this change. Change subject: core: add custom properties to templates ......................................................................
Patch Set 2: (1 comment) new patch to fix comment + fixing unit-tests failure by extracting code that calls static PropertiesUtil to method and override it in tests. http://gerrit.ovirt.org/#/c/35117/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java: Line 176: if (getParameters().getVmTemplateData().getMinAllocatedMem() > getParameters().getVmTemplateData().getMemSizeMb()) { Line 177: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_MIN_MEMORY_CANNOT_EXCEED_MEMORY_SIZE); Line 178: } Line 179: Line 180: if (!VmPropertiesUtils.getInstance().validateVmProperties( > you can call #getVmPropertiesUtils that you added instead Done Line 181: getVdsGroup().getcompatibility_version(), Line 182: getParameters().getVmTemplateData().getCustomProperties(), Line 183: getReturnValue().getCanDoActionMessages())) { Line 184: return false; -- To view, visit http://gerrit.ovirt.org/35117 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85f8fb998b5e081c10d93e5790963fb7b8bdf5fd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
