Sandro Bonazzola has posted comments on this change. Change subject: node: added persistent storage configuration ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34438/1/src/plugins/ovirt-hosted-engine-setup/core/misc.py File src/plugins/ovirt-hosted-engine-setup/core/misc.py: Line 101: try: Line 102: # avoid: pyflakes 'Config' imported but unused error Line 103: import ovirt.node.utils.fs Line 104: if hasattr(ovirt.node.utils.fs, 'Config'): Line 105: self.environment[ohostedcons.CoreEnv.NODE_SETUP] = True > Shouldn't we raise an error here if we can not find the Config attr? Well, original code just used the import for knowing if we were on node or not, this is just a way for avoiding pyflakes to complain about importing a module and not using it. We can log a warning or a debug message but since we're not really using the Config class I'm not really sure we should raise an exception on this. Line 106: except ImportError: Line 107: self.logger.debug('Disabling persisting file configuration') Line 108: Line 109: @plugin.event( -- To view, visit http://gerrit.ovirt.org/34438 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67afe1d994437eac841cc4217ed39f68d5b12374 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
