Sandro Bonazzola has uploaded a new change for review.

Change subject: postgresql: avoid to crash with numerical passwords
......................................................................

postgresql: avoid to crash with numerical passwords

Issue: https://github.com/sosreport/sos/issues/433
Change-Id: I29d0109dcf053387203fe7e10f45b68d8543c5ff
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1133993
Signed-off-by: Sandro Bonazzola <[email protected]>
---
M src/sos/plugins/postgresql.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-log-collector 
refs/changes/66/35166/1

diff --git a/src/sos/plugins/postgresql.py b/src/sos/plugins/postgresql.py
index 2c48a20..eda0eaa 100644
--- a/src/sos/plugins/postgresql.py
+++ b/src/sos/plugins/postgresql.py
@@ -68,7 +68,7 @@
         # is no need to save and restore environment variables if the user
         # decided to pass the password on the command line.
         if self.getOption("password") is not False:
-            os.environ["PGPASSWORD"] = self.getOption("password")
+            os.environ["PGPASSWORD"] = str(self.getOption("password"))
 
         if self.getOption("dbhost"):
             cmd = "pg_dump -U %s -h %s -p %s -w -f %s -F t %s" % (


-- 
To view, visit http://gerrit.ovirt.org/35166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I29d0109dcf053387203fe7e10f45b68d8543c5ff
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to