Sandro Bonazzola has posted comments on this change. Change subject: win32: Set registry value with SetValueEx not SetValue ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/35163/2/ovirt-guest-agent/GuestAgentWin32.py File ovirt-guest-agent/GuestAgentWin32.py: Line 231: RETIRES = 3 Line 232: try: Line 233: self._performSAS() Line 234: except Exception: Line 235: logging.warning("Failed to perform SAS", exc_info=True) This change is not documented in the commit message. Now if it fails to simulate a SAS it try to login anyway. If the result of the simulation is not important, better to drop it at all. Line 236: try: Line 237: retries = 1 Line 238: while retries <= RETIRES: Line 239: try: -- To view, visit http://gerrit.ovirt.org/35163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51d70381de43d62e96f9f24de60bdf0226e20f54 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
