Vojtech Szocs has posted comments on this change. Change subject: frontend: Pass JSESSIONID in VV file ......................................................................
Patch Set 9: (2 comments) Two minor comments in GwtDynamicHostPageServlet.java - looks good otherwise. http://gerrit.ovirt.org/#/c/33770/9/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java: Line 294: } Line 295: } Line 296: Line 297: // Update based on engineSessionTimeout object Line 298: digest.update(request.getAttribute(ATTR_ENGINE_SESSION_TIMEOUT).toString().getBytes()); > getBytes uses the default encoding, this will trigger a Coverity warning, p +1 please use explicit charset. Line 299: Line 300: return digest; Line 301: } Line 302: Line 305: } Line 306: Line 307: private Integer getEngineSessionTimeout(String sessionId) { Line 308: return (Integer) runPublicQuery(VdcQueryType.GetConfigurationValue, Line 309: new GetConfigurationValueParameters(ConfigurationValues.UserSessionTimeOutInterval, Please use conventional indentation in accordance with config/engine-code-format.xml rules (too much indentation here). Line 310: ConfigCommon.defaultConfigurationVersion), sessionId); Line 311: } Line 312: Line 313: protected ObjectNode getEngineSessionTimeoutObject(Integer engineSessionTimeout) { -- To view, visit http://gerrit.ovirt.org/33770 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5c6d2c91b99240527760b57a6079b5f986aff5b Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
