Sharad Mishra has posted comments on this change. Change subject: bootstrap: move node id creation command to configuration ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) Please look at inline comments. Also, on my clone (which was updated this morning), compile fails because org/ovirt/engine/core/bll/VdsInstallHelper.java is still looking for _getUniqueIdCommand. I noticed that now there is some sort of automated jenkins build on all submitted patches. The build succeeded on this patch which makes me wonder if there is something wrong with my setup as the above inline comments should have caused the build to fail. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java Line 282: Config.<String> GetValue(ConfigValues.BootstrapNodeIDCommand); extra semicolon at the end .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java Line 1421: ); Don't need a semicolon at the end -- To view, visit http://gerrit.ovirt.org/7068 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a575e2bf391ca6b1cf7e8baa2d8c5813e10c97f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
