Yair Zaslavsky has submitted this change and it was merged. Change subject: engine : CommandBase should not set end status for commands with callback ......................................................................
engine : CommandBase should not set end status for commands with callback When mixing async tasks and async commands if a callback is provided by the command the CommandBase should not set the status of the command. The command should override endSuccessfully and endWithFailure to set the status of the async tasks status to succeeded or failed. Change-Id: I84c05917003376d2f62d3da7acecd889f8cb79e0 Bug-Url: https://bugzilla.redhat.com/1160872 Signed-off-by: Ravi Nori <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java 2 files changed, 39 insertions(+), 3 deletions(-) Approvals: Greg Padgett: Verified Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84c05917003376d2f62d3da7acecd889f8cb79e0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
