Doron Fediuck has posted comments on this change. Change subject: Fix calculation of score for gateway and bridge problems. ......................................................................
Patch Set 1: (1 comment) See inline. http://gerrit.ovirt.org/#/c/35203/1/ovirt_hosted_engine_ha/agent/hosted_engine.py File ovirt_hosted_engine_ha/agent/hosted_engine.py: Line 770: # collect all local stats Line 771: self._log.debug("Refreshing all submonitors") Line 772: for field, monitor in self._local_monitors.iteritems(): Line 773: ret = self._broker.get_monitor_status(monitor['id']) Line 774: if ret == 'False': This can only be checked after verifying ret in not none. Line 775: ret = False Line 776: elif monitor['type'] is not None: Line 777: ret = monitor['type'](ret) Line 778: data["local"][field] = ret -- To view, visit http://gerrit.ovirt.org/35203 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id750ef496ae1983be20b9bd61d5757fc37ba39b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Artyom Lukianov <[email protected]> Gerrit-Reviewer: Artyom Lukianov <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
