Alon Bar-Lev has posted comments on this change. Change subject: aaa: enable accept engine session using header ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/35069/6//COMMIT_MSG Commit Message: Line 6: Line 7: aaa: enable accept engine session using header Line 8: Line 9: new header OVIRT-INTERNAL-ENGINE-AUTH-TOKEN accepts token that is signed Line 10: engine session id, as session id is plain uuid which is not enough > kinda surprises as me as uuid is 128 bit, no? maybe the problem is with th no 128 is not enough. in 3.6 we will have plain strings session id so we can drop this. if you think that session id can be non uuid in 3.5, I will be more than happy to remove the mac and replace the session id with something random. Line 11: random. Line 12: Line 13: a new query GetEngineSessionIdToken returns this token. Line 14: -- To view, visit http://gerrit.ovirt.org/35069 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I028082cced7043b5af0b9fa7b0548ba888996e9d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
