Eli Mesika has posted comments on this change. Change subject: RFE: Add Granular permissions for VM operations ......................................................................
Patch Set 1: (4 comments) http://gerrit.ovirt.org/#/c/35206/1/packaging/dbscripts/upgrade/03_06_0520_INSERT_GRANULAR_VM_ROLES.sql File packaging/dbscripts/upgrade/03_06_0520_INSERT_GRANULAR_VM_ROLES.sql: please rename the file to be all in lowercase Line 1: -- We change the VM permission to be more granular, Line 2: -- instead of grouping the reboot, stop, shut down, hibernate, run and run-once Line 3: -- into basic operation each is now a role group Line 4: CREATE OR REPLACE FUNCTION update_vm_basic_roles() Line 4: update_vm_basic_roles please rename function to __temp_update_vm_basic_roles Line 22: CLOSE v_cur; Line 23: END; $procedure$ Line 24: LANGUAGE plpgsql; Line 25: Line 26: SELECT * from update_vm_basic_roles(); SELECT __temp_update_vm_basic_roles(); Line 27: DROP FUNCTION update_vm_basic_roles(); Line 23: END; $procedure$ Line 24: LANGUAGE plpgsql; Line 25: Line 26: SELECT * from update_vm_basic_roles(); Line 27: DROP FUNCTION update_vm_basic_roles(); __temp_update_vm_basic_roles() -- To view, visit http://gerrit.ovirt.org/35206 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ae2d6ad2ebc6c8e0948abe1c413362f4e3dbda7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
