Maor Lipchuk has posted comments on this change.

Change subject: core: Allow SD maintenance with suspended vms
......................................................................


Patch Set 5: Code-Review+1

The patch looks ok to me.
IIRC an attached Storage Domain can be removed only if:
1. It is the last Storage Domain in the Data Center and we remove the Data 
Center
2. Removing the Storage Domain by Force Remove.

Omer, did you verify this with Local Storage Domain?
Currently local Storage Domain format the Storage Domain on detach.

Liron do you have any insights about this?

-- 
To view, visit http://gerrit.ovirt.org/32201
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0206fb7a1a0c59ff493635e5cb84805b3a9a354
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to