Alexander Wels has posted comments on this change. Change subject: webadmin: Use existing Engine session for REST API integration ......................................................................
Patch Set 2: (1 comment) One question, can we rename SESSION_ID to REST_CSRF_TOKEN or something similar, as that is now really the only thing it is used for. http://gerrit.ovirt.org/#/c/35185/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java: Line 106: RequestBuilder builder = new RequestBuilder(RequestBuilder.GET, restApiBaseUrl); Line 107: Line 108: // Map this (physical) REST API session to current user's (logical) Engine session Line 109: if (engineAuthToken != null) { Line 110: builder.setHeader(ENGINE_AUTH_TOKEN_HEADER, engineAuthToken); As Alon said, you can move this into the other if (engineAuthToken != null) Line 111: } Line 112: Line 113: // Control REST API session timeout Line 114: builder.setHeader("Session-TTL", restApiSessionTimeout); //$NON-NLS-1$ -- To view, visit http://gerrit.ovirt.org/35185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3905b3b5834a0f7327321e93064274df0d1db65 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
