Juan Hernandez has posted comments on this change. Change subject: utils: ssh public key entry should contain new line ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/OpenSSHUtils.java Line 116: final StringBuilder buffer = new StringBuilder(SSH_RSA.length() + 1 + encoding.length() + (alias != null? 1 + alias.length(): 0)); If it is easy to calculate the exact size of the buffer it is better to allocate exactly that. Allocating less means that the buffer has to be dynamically enlarged, probably several times (default size is 16 characters) and that means allocating new arrays and copying the contents. If you use a larger value the space is just wasted. -- To view, visit http://gerrit.ovirt.org/7027 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd202048b8efb8f081b10651c302b9da0718035c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
