Piotr Kliczewski has posted comments on this change. Change subject: engine: Enable Long xmlrpc support for new VM and disk hotplug ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35279/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java: Line 57: vmCreate Both method seems to be copied from vdsm. If we want to have those methods here we need to use 'create' and 'hotplugDisk'. Please take a look at vdsm side mapping in BindingXMLRPC.py method getGlobalMethods. Both methods use maps so the current code won't iterate over maps to update the type. -- To view, visit http://gerrit.ovirt.org/35279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82673b6dec7ba320c56a1cf6e0cd3f1dde86fd22 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
