Ayal Baron has posted comments on this change.
Change subject: core: validate storage format by DataCenter version
......................................................................
Patch Set 3: (7 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
Line 150: private boolean correctStorageDomainFormat() {
Probably for a different patch, but the name of this method is not clear.
Line 154: StorageDomainType storageDomainType =
getStorageDomain().getstorage_domain_type();
I still think that the name of this variable should change
Line 156: Set<StorageFormatType> supportedStorageFormats;
The purpose of adding an SD which is not connected to a pool is in order to run
initialize data center only. That is the only flow we support.
Hence, user should not be able to use a host which is not connected to a pool.
Line 167: }
I think all code up to this point should be in a separate method
Line 169: boolean isBlockStorage = storageType == StorageType.ISCSI ||
storageType == StorageType.FCP;
the following validations also warrant a method of their own imo.
....................................................
Commit Message
Line 14: correlate with the DataCenter's compatibility version.
s/correlate/correlation/
s/DataCenter's/data center's/
Line 17: SupportedStorageFormats ConfigurationValue,
Added V2 to 3.1 DCs in ...
--
To view, visit http://gerrit.ovirt.org/6990
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia062c1587bc6c35c7ec27270d450d1e312742086
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
