Ofer Schreiber has posted comments on this change. Change subject: packaging: Do not allow whitespaces in passwords (#BZ835363) ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) 1. please change commit msg 2. I don't get why the msg is a "warning" and not "error" as alex asked you to change. Warning = Small issue, but we let you go with it. Error = Re-enter value .................................................... Commit Message Line 11: This patch not allows whitespaces in passwords in engine-setup. Better - Do not allow whitespaces in passwords... -- To view, visit http://gerrit.ovirt.org/7033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia29fb22c53f45d735f1d722ae9a80e5ccbb2246b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
